RXP ro · they/them
ro approved projects/thebadspace#20 2025-05-05 22:17:29 +02:00
fix: removes an errand <body>-tag

Oops. Thanks for catching this.

ro merged pull request projects/thebadspace#23 2025-05-05 22:13:36 +02:00
Refactor: about page
ro pushed to develop at projects/thebadspace 2025-05-05 22:13:36 +02:00
0ad5208638 Merge pull request 'Refactor: about page' (#23) from moiety/about into develop
8ed702bd59 Merge branch 'develop' into moiety/about
cf11d246d1 refactor: current sources
2c88d45e52 style: make indentation consistent
Compare 4 commits »
ro approved projects/thebadspace#23 2025-05-05 22:13:25 +02:00
Refactor: about page

indentation in php files might be a bit wonky because it's being handled by some formatting setting in Nova itself. I may have to make some adjustments to those configs to get it where it needs to be.

ro pushed to moiety/about at projects/thebadspace 2025-05-05 22:12:05 +02:00
8ed702bd59 Merge branch 'develop' into moiety/about
a0fee9b6b1 Merge pull request 'Refactor index meta' (#22) from moiety/infex-meta into develop
5515503117 fix: set meta-index padding
0f16b275a0 refactor: use a <table>-element for index-meta
d138198305 feat: add visually-hidden utility
Compare 5 commits »
ro pushed to develop at projects/thebadspace 2025-05-05 22:08:48 +02:00
a0fee9b6b1 Merge pull request 'Refactor index meta' (#22) from moiety/infex-meta into develop
5515503117 fix: set meta-index padding
0f16b275a0 refactor: use a <table>-element for index-meta
d138198305 feat: add visually-hidden utility
Compare 4 commits »
ro merged pull request projects/thebadspace#22 2025-05-05 22:08:46 +02:00
Refactor index meta
ro approved projects/thebadspace#22 2025-05-05 22:07:42 +02:00
Refactor index meta

Ha, my instincts are reacting to the tables, but that's just old web person trauma.

ro commented on pull request projects/thebadspace#21 2025-05-05 22:05:07 +02:00
Refactor home search

Never mind. I misunderstood what these changes do.

This is all good.

ro commented on pull request projects/thebadspace#18 2025-05-05 21:01:31 +02:00
feat: add lang-attribute to the html-element

It's all good for right now. It will probably be changed a few times anyway in the localization process.

ro commented on pull request projects/thebadspace#19 2025-05-05 21:00:13 +02:00
feat: move/refactor navigation

The implementation was correct, so that's cool. I just don't use it, so you introduced a new idea that might be a better way to handle views, so I'm just taking a beat to think about the future…

ro commented on pull request projects/thebadspace#22 2025-05-05 19:21:50 +02:00
Refactor index meta

Definitely. I came up when I.E was popular lol

ro commented on pull request projects/thebadspace#19 2025-05-05 19:20:59 +02:00
feat: move/refactor navigation

I don't have View Components on the backend as I run everything through Controllers.

I'm trying to decide if that's something I want to implement site wide or keep the same structure that…

ro commented on pull request projects/thebadspace#16 2025-05-05 16:10:51 +02:00
Read project version from composer.json

I honestly don't know what the best practice is for this scenario, so this works for me.

If we need to change it later, we will.

ro commented on pull request projects/thebadspace#17 2025-05-05 16:09:58 +02:00
fix: set alt text for the logo

👍🏾

ro commented on pull request projects/thebadspace#18 2025-05-05 16:09:28 +02:00
feat: add lang-attribute to the html-element

I was holding off on this because this was a part of the localization effort that I was going to get into soon, but it doesn't hurt to add this now.

ro commented on pull request projects/thebadspace#19 2025-05-05 16:08:09 +02:00
feat: move/refactor navigation

I think moving navigation to it's own thing is fine, but this PR also introduces a new paradigm that could have implications down the road.

I'm gonna think about this one for a bit.

ro commented on pull request projects/thebadspace#20 2025-05-05 16:05:23 +02:00
fix: removes an errand <body>-tag

👍🏾

ro commented on pull request projects/thebadspace#21 2025-05-05 16:04:43 +02:00
Refactor home search

Overall, I think these are fine, but I want the focus indicator on the search to be loud. That's the reason for the color flip. If it needs more contrast, I'll work on that, but I don't want…

ro commented on pull request projects/thebadspace#22 2025-05-05 16:02:51 +02:00
Refactor index meta

Ha, I have a deep, philosophical hate of tables, but this makes sense, so it's cool.