feat: move/refactor navigation #19
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "moiety/nav-list"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
moves the navigation code into its own component. this also refactors it into a list, this is generally helpful for AT as those can now announce the number of links. another thing is that the open button is moved into the
<nav>-element. this makes it so that if someone were to navigate to the<nav>-element they’d be able open the menu from there.i’d like to do a further refactor (especially the open/close mechanism) but this is a good start :)
I think moving navigation to it's own thing is fine, but this PR also introduces a new paradigm that could have implications down the road.
I'm gonna think about this one for a bit.
Thank you for the feedback. Can you explain what you mean by “new paradigm”? i’m not really sure what that means. happy to change things.
I don't have View Components on the backend as I run everything through Controllers.
I'm trying to decide if that's something I want to implement site wide or keep the same structure that exists now.
Oh I see, i just followed the laravel component thing. I don’t know much about PHP to be honest, so if i can do that some other way i’m happy to learn/look that up.
The implementation was correct, so that's cool. I just don't use it, so you introduced a new idea that might be a better way to handle views, so I'm just taking a beat to think about the future implications, i.e. is it better to refactor views now, or just stick with what's there now.
5883d2111ftob921134002