projects/thebadspace
projects/thebadspace
1
0
Fork 0
Code Issues 11 Pull requests 6 Projects Releases 3 Packages Wiki Activity Actions

feat: move/refactor navigation #19

Open
Moiety wants to merge 1 commit from moiety/nav-list into develop
pull from: moiety/nav-list
merge into: projects:develop
Conversation 5 Commits 1 Files changed 4 +91 -46
Moiety commented 2025-05-02 00:31:54 +02:00
Collaborator
Copy link

moves the navigation code into its own component. this also refactors it into a list, this is generally helpful for AT as those can now announce the number of links. another thing is that the open button is moved into the <nav>-element. this makes it so that if someone were to navigate to the <nav>-element they’d be able open the menu from there.

i’d like to do a further refactor (especially the open/close mechanism) but this is a good start :)

moves the navigation code into its own component. this also refactors it into a list, this is generally helpful for AT as those can now announce the number of links. another thing is that the open button is moved into the `<nav>`-element. this makes it so that if someone were to navigate to the `<nav>`-element they’d be able open the menu from there. i’d like to do a further refactor (especially the open/close mechanism) but this is a good start :)
Moiety added 1 commit 2025-05-02 00:31:54 +02:00 
moves the navigation code into its own component. this also refactors it into a list, this is generally helpful for AT as those can now announce the number of links. another thing is that the open button is moved into the <nav>-element. this makes it so that if someone were to navigate to the <nav>-element they’d be able open the menu from there.
ro commented 2025-05-05 16:08:09 +02:00
Collaborator
Copy link

I think moving navigation to it's own thing is fine, but this PR also introduces a new paradigm that could have implications down the road.

I'm gonna think about this one for a bit.

I think moving navigation to it's own thing is fine, but this PR also introduces a new paradigm that could have implications down the road. I'm gonna think about this one for a bit.
👍 1
Moiety commented 2025-05-05 18:05:37 +02:00
Author
Collaborator
Copy link

Thank you for the feedback. Can you explain what you mean by “new paradigm”? i’m not really sure what that means. happy to change things.

Thank you for the feedback. Can you explain what you mean by “new paradigm”? i’m not really sure what that means. happy to change things.
ro commented 2025-05-05 19:20:59 +02:00
Collaborator
Copy link

I don't have View Components on the backend as I run everything through Controllers.

I'm trying to decide if that's something I want to implement site wide or keep the same structure that exists now.

I don't have View Components on the backend as I run everything through Controllers. I'm trying to decide if that's something I want to implement site wide or keep the same structure that exists now.
Moiety commented 2025-05-05 19:48:47 +02:00
Author
Collaborator
Copy link

Oh I see, i just followed the laravel component thing. I don’t know much about PHP to be honest, so if i can do that some other way i’m happy to learn/look that up.

Oh I see, i just followed the laravel component thing. I don’t know much about PHP to be honest, so if i can do that some other way i’m happy to learn/look that up.
ro commented 2025-05-05 21:00:13 +02:00
Collaborator
Copy link

The implementation was correct, so that's cool. I just don't use it, so you introduced a new idea that might be a better way to handle views, so I'm just taking a beat to think about the future implications, i.e. is it better to refactor views now, or just stick with what's there now.

The implementation was correct, so that's cool. I just don't use it, so you introduced a new idea that might be a better way to handle views, so I'm just taking a beat to think about the future implications, i.e. is it better to refactor views now, or just stick with what's there now.
❤️ 1
Moiety force-pushed moiety/nav-list from 5883d2111f to b921134002 2025-05-05 22:46:16 +02:00 Compare
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin moiety/nav-list:moiety/nav-list
git checkout moiety/nav-list

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout develop
git merge --no-ff moiety/nav-list
git checkout moiety/nav-list
git rebase develop
git checkout develop
git merge --ff-only moiety/nav-list
git checkout moiety/nav-list
git rebase develop
git checkout develop
git merge --no-ff moiety/nav-list
git checkout develop
git merge --squash moiety/nav-list
git checkout develop
git merge --ff-only moiety/nav-list
git checkout develop
git merge moiety/nav-list
git push origin develop
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility

Issues relating to assistive technologies

  
API

How external services connect to TBS

  
backend

The guts of how the site works

  
bug

Something is not working

  
database

Issues related to the where the info is stored

  
Docs

Instruction and details on the important bits

  
UI/UX

Frontend look and feel

No labels
accessibility
API
backend
bug
database
Docs
UI/UX
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: projects/thebadspace#19
No description provided.
Delete branch "moiety/nav-list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?