projects/thebadspace
projects/thebadspace
1
0
Fork 0
Code Issues 11 Pull requests 6 Projects Releases 3 Packages Wiki Activity Actions

Refactor: about page #23

Merged
ro merged 3 commits from moiety/about into develop 2025-05-05 22:13:36 +02:00
Conversation 5 Commits 3 Files changed 2 +72 -77
Moiety commented 2025-05-02 21:00:48 +02:00
Collaborator
Copy link

This changes the following:

  • make indentation consistent
  • adds in missing HTML tags (some <p>s here and there)
  • <strong> → <h3>
  • add a .strong class to mimic the <strong> behaviour
  • wrap current sources lists in <ul>
  • provide feedback when no sources are available
This changes the following: - make indentation consistent - adds in missing HTML tags (some `<p>`s here and there) - `<strong>` → `<h3>` - add a `.strong` class to mimic the `<strong>` behaviour - wrap current sources lists in `<ul>` - provide feedback when no sources are available
Moiety added 2 commits 2025-05-02 21:00:48 +02:00 
also adds some HTML tags here and there but doesn’t change any content.
changes:
- `<strong>` → `<h3>`
- add a `.strong` class to mimic the `<strong>` behaviour
- wrap lists in `<ul>`
- provide feedback when no sources are available
ro commented 2025-05-05 15:58:54 +02:00
Collaborator
Copy link

Yeah, I like this. This needed to be cleaned up.

Yeah, I like this. This needed to be cleaned up.
ro added 1 commit 2025-05-05 22:12:05 +02:00
ro approved these changes 2025-05-05 22:13:25 +02:00
ro left a comment
Collaborator
Copy link

indentation in php files might be a bit wonky because it's being handled by some formatting setting in Nova itself. I may have to make some adjustments to those configs to get it where it needs to be.

indentation in php files might be a bit wonky because it's being handled by some formatting setting in Nova itself. I may have to make some adjustments to those configs to get it where it needs to be.
ro merged commit 0ad5208638 into develop 2025-05-05 22:13:36 +02:00
Moiety deleted branch moiety/about 2025-05-05 22:36:08 +02:00
Moiety commented 2025-05-05 22:37:03 +02:00
Author
Collaborator
Copy link

Oh cool you use Nova too? Nice. I wanted to suggest maybe using Prettier?

Oh cool you use Nova too? Nice. I wanted to suggest maybe using [Prettier](https://prettier.io/)?
ro commented 2025-05-05 22:39:10 +02:00
Collaborator
Copy link

I do use Prettier but I don't use Prettier for PHP formatting.

Should I?

I do use Prettier but I don't use Prettier for PHP formatting. Should I?
Moiety commented 2025-05-05 22:44:19 +02:00
Author
Collaborator
Copy link

I’ve not used it for that tbh. I don’t see it in the default list of supported language now that i’m looking into it. There might be a plugin though. I can look into it further sometime this week if you want. Would make things run a bit smoother re random white space showing up in PRs :)

I’ve not used it for that tbh. I don’t see it in the default list of supported language now that i’m looking into it. There might be a plugin though. I can look into it further sometime this week if you want. Would make things run a bit smoother re random white space showing up in PRs :)
ro commented 2025-05-05 22:53:20 +02:00
Collaborator
Copy link

There's an .editorconfig file that handles some spacing stuff, but the bulk of it is handled by the php-cs-fixer.php file.

everything else (js, css) is handled by Prettier, so if you want to update those settings, feel free

There's an `.editorconfig` file that handles some spacing stuff, but the bulk of it is handled by the `php-cs-fixer.php` file. everything else (js, css) is handled by Prettier, so if you want to update those settings, feel free
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
ro
Labels
Clear labels   
accessibility

Issues relating to assistive technologies

  
API

How external services connect to TBS

  
backend

The guts of how the site works

  
bug

Something is not working

  
database

Issues related to the where the info is stored

  
Docs

Instruction and details on the important bits

  
UI/UX

Frontend look and feel

No labels
accessibility
API
backend
bug
database
Docs
UI/UX
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: projects/thebadspace#23
No description provided.
Delete branch "moiety/about"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?