feat: add lang-attribute to the html-element

Moiety commented

2025-05-02 00:18:36 +02:00

Collaborator

this helps computers interpret and manipulate the website content (example: pronunciation for assistive tech). if tbs ever gets a language setting that should be reflected here.

Moiety added 1 commit 2025-05-02 00:18:36 +02:00

feat: add lang-attribute to the html-element e1119c71b9

this helps computers interpret and manipulate the website content (example: pronunciation for assistive tech). if tbs ever gets a language setting that should be reflected here.

ro commented

2025-05-05 16:09:28 +02:00

Collaborator

I was holding off on this because this was a part of the localization effort that I was going to get into soon, but it doesn't hurt to add this now.

👍 1

Moiety commented

2025-05-05 19:50:58 +02:00

Author

Collaborator

There’s a line in welcome.blade.php:

<html lang="{{ str_replace('_', '-', app()->getLocale()) }}">

Could also use that, seems to give the same result atm. Happy to change it if you want :)

There’s a line in `welcome.blade.php`: ``` <html lang="{{ str_replace('_', '-', app()->getLocale()) }}"> ``` Could also use that, seems to give the same result atm. Happy to change it if you want :)

ro commented

2025-05-05 21:01:31 +02:00

Collaborator

It's all good for right now. It will probably be changed a few times anyway in the localization process.

👍 1

Moiety force-pushed moiety/page-lang from e1119c71b9 to d2efe4f65e

2025-05-05 22:41:22 +02:00

Compare

Moiety force-pushed moiety/page-lang from d2efe4f65e to 6af048ab2a

2025-05-05 22:47:03 +02:00

Compare

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin moiety/page-lang:moiety/page-lang

git checkout moiety/page-lang

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout develop

git merge --no-ff moiety/page-lang

git checkout moiety/page-lang

git rebase develop

git checkout develop

git merge --ff-only moiety/page-lang

git checkout moiety/page-lang

git rebase develop

git checkout develop

git merge --no-ff moiety/page-lang

git checkout develop

git merge --squash moiety/page-lang

git checkout develop

git merge --ff-only moiety/page-lang

git checkout develop

git merge moiety/page-lang

git push origin develop

Rows
Columns

feat: add lang-attribute to the html-element #18

Checkout

Merge