WIP: Fix for #109, add toggle state to buttons #112

Closed

Moiety wants to merge 1 commit from toggle-buttons-#109 into develop

Moiety commented

2023-07-25 12:53:58 +02:00

(Migrated from koodu.ubiqueros.com)

Adds aria-pressed to the “Options” toggle buttons; this communicates their state to assistive technologies.

are0h commented

2023-07-27 23:17:26 +02:00

(Migrated from koodu.ubiqueros.com)

The CSS doesn't render. I changed it a few weeks back to just be pure CSS that lives in the public/assets directory. The style directory full of SCSS files is legacy that I use to reference from time to time, but it's not used by the build anymore.

I appreciate the hold off. This is pretty significant change that affects the CSS as well, so I'll more than likely make that change as I redo the CSS and remove all of the invalid role attributes I used through out.

The CSS doesn't render. I changed it a few weeks back to just be pure CSS that lives in the `public/assets` directory. The style directory full of SCSS files is legacy that I use to reference from time to time, but it's not used by the build anymore. I appreciate the hold off. This is pretty significant change that affects the CSS as well, so I'll more than likely make that change as I redo the CSS and remove all of the invalid `role` attributes I used through out.

Moiety commented

2023-07-28 08:21:04 +02:00

(Migrated from koodu.ubiqueros.com)

The current implementation doesn’t rely on any CSS changes; both the data-active and aria-pressed are still present. If you want this is ready to go!

The current implementation doesn’t rely on any CSS changes; both the `data-active` and `aria-pressed` are still present. If you want this is ready to go!