All pages use role
-attributes with invalid values
#99
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: projects/fipamo#99
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Pages: all pages tested (including: login, dashboard, create/edit page)
The
role
-attribute is used to set specific accessibility semantics; there’s only a limited set of valid values that apply to specific components. By the looks of it Fipamo uses therole
-attribute purely for styling. Can you elaborate on why you chose this attribute?One way to resolve this is to replace the
role
-attributes with classes.As an example, from _frame.twig:
None of the values provided here are valid; this causes accessibility issues.
Ro Edit
The following pages need to be updated to remove the invalid role attributes and make the appropriate adjustments to the scripting to longer reference these attributes.
The intention was to use role as a CSS anchor and describe what the block was being used for, so I got a bit carried away with it.
The HTML already relies on semantic HTML, so I can edit these files to remove most of the role tags and change the ones I do keep with valid values.
I'm going to start with this one because it's the most complex.
I have to edit every page style along with the JS that is referencing the
role
attribute specifically.This will touch just about every system on the site, so I'm going to be methodical about getting this cleaned up so I don't send the codebase into a tailspin.
Let me know if you want some help with this. We could do some pair programming if you want.
All invalid role tags have been removed.