xarvh/fipamo
1
0
Fork 0
forked from projects/fipamo
Code Pull requests Activity

fix for tag sorting and html page render

Browse source 
when sorting tags on a fresh install, a fatal error happens when the tag
array is empty because it looks for a var that doesn't exist yet. that's
been patched

the settings json file was still referencing the old version of the base
theme, so it was crashing because it doesn't exist anymore. updating it
to the new theme name clears this error
This commit is contained in:
ro 2024-06-04 15:19:46 -06:00
parent 8704fdcfe1
commit 9923f087a6
No known key found for this signature in database
GPG key ID: 29B551CDBD4D3B50
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/Services/Data/SortingService.php
View file

@ -60,14 +60,17 @@ class SortingService
} }
$tagData = []; $tagData = [];
//dd($this->settings->getTags()['pages']); $settingsTags = [];
if (isset($this->settings->getTags()['pages'])) {
$settingsTags = $this->settings->getTags()['pages'];
}
$tagData = [ $tagData = [
'debug' => $debug, // for theme kit 'debug' => $debug, // for theme kit
'tags' => $this->p_tags, 'tags' => $this->p_tags,
'theme' => $this->info['theme'], // for theme kit 'theme' => $this->info['theme'], // for theme kit
'title' => 'Pages Tagged as Tag', 'title' => 'Pages Tagged as Tag',
'dynamicRender' => $this->info['dynamicRender'], 'dynamicRender' => $this->info['dynamicRender'],
'pages' => $this->settings->getTags()['pages'], 'pages' => $settingsTags,
'info' => $this->info, 'info' => $this->info,
'menu' => $this->settings->getMenu(), 'menu' => $this->settings->getMenu(),
'media' => [ 'media' => [

2
content/init/settings-template.json
View file

@ -6,7 +6,7 @@
"background": "/assets/images/global/default-bg.jpg", "background": "/assets/images/global/default-bg.jpg",
"private": "true", "private": "true",
"renderOnSave": "false", "renderOnSave": "false",
"theme": "fipamo-default", "theme": "fipamo-default-v2",
"display_limit": 5, "display_limit": 5,
"last_backup": null, "last_backup": null,
"externalAPI": "false", "externalAPI": "false",