projects/love_fipamo

Fork 1

Fix clippy lints #1

Merged

ro merged 35 commits from federico/love_fipamo:appease-clippy into develop

2025-10-03 22:28:48 +02:00

federico commented

2025-10-03 17:39:26 +02:00

Contributor

This PR fixes all the lints from cargo clippy. I have tried to gather similar lints into single commits, but there's many lints, so there's a bunch of commits :)

None of this changes functionality; it's just code style as per clippy.

This PR fixes all the lints from `cargo clippy`. I have tried to gather similar lints into single commits, but there's many lints, so there's a bunch of commits :) None of this changes functionality; it's just code style as per clippy.

federico added 35 commits

2025-10-03 17:39:26 +02:00

clippy: fix redundant field names in struct initialization 165448d028

If you have a variable `foo` with the same name as a struct field
some_struct.foo, you can just initialize the struct field with its
name without specifying the variable.

clippy: remove unused import f97622c0dd

clippy: don't use temporary bindings to immediately return values 355dc1b46f

Instead of

  fn foo() -> Bar {
      let bar = Bar { ... };
      bar
  }

just use

  fn foo() -> Bar {
      Bar { ... }
  }

clippy: Remove redundant unwrap() 0c149ffc3c

Remove redundant "if" statements 43a5a50942

Also, compare these:

pub struct Global {
    pub render_on_save: bool,
    pub external_api: bool,
    pub dynamic_render: bool,
    ...
}

pub struct GlobalEdit {
    pub render_on_save: String,
    pub external_api: String,
    pub dynamic_render: String,
    ...
}

I think GlobalEdit could use bool fields as well?

Replace is_none() and then unwrap() with an "if let" binding 559d4f4efa

Simplify turning a None into a "" String 0141c3ebee

Replace comparisons against "" with !s.is_empty() efe7b2d422

Don't use late initialization 9ef09f3310

No need to compare booleans against true ea5d70823e

Use is_none() instead of comparing to None 2f2a5771ec

Use is_empty() instead of comparing to 0 d8cef6d6f3

Use += instead of + 1 8ce2d45a29

Remove superfluous cast ba49da04d5

range is already i32

Use is_empty() instead of comparing to 0 251eeae805

Turn is_none() and then unwrap() into an "if let" binding f1d8773a7b

This also puts the happy path in the "then", and leaves the "else" for
the error path, which is nicer.

Remove superfluous reference 1781fee907

Don't use late initialization bada64bd9b

Remove superfluous clones 94687669f8

The + operator is defined for String + &str, so for the second operand
we can just ask for the as_str() of an existing String.

Don't use late initialization a1cad2ed00

Don't use late initialization; bind a tuple instead 81b58ed976

This makes it easier to spot cases when a match case forgets to set
either variable.

Remove superfluous conversion to an owned String ec64be3d54

.trim() just re-slices the given slice, and we can use that for ==

Don't use late initialization a9884a7973

Remove unnecessary to_string() 252af23350

env::var() returns Option<String> already

Remove superfluous reference 0439ec5ba0

Don't use late initialization 8bb4cf82af

Don't use late initialization, and return result directly e5476fb881

Remove unnecessary vec! 5059c0eaaf

vec! allocates, but set_audience() takes a &[T] where T: ToString, so
just pass it a static slice.

Use !iter().any() instead of iter().find().is_none() 242f2528ae

Trim each tag only once, not once for every step through the tag_list d28e454951

Remove superfluous reference 4e29b26eeb

Collapse nested if statements 959992b0da

Note unused argument d5d80b3005

Remove unused variable 9cd6f9a051

Note unused argument 8553f52351

ro commented

2025-10-03 21:51:05 +02:00

Collaborator

These changes look great.

Just update this branch with the latest in develop and then I'll merge.

I won't make any changes to the main branch to make it easier.

EDIT: Ha, ok, maybe one little commmit, but that's it. I'll freeze anymore more changes until this is done.

These changes look great. Just update this branch with the latest in `develop` and then I'll merge. I won't make any changes to the main branch to make it easier. EDIT: Ha, ok, maybe one little commmit, but that's it. I'll freeze anymore more changes until this is done.

federico force-pushed appease-clippy from 8553f52351 to 5a36dfa501

2025-10-03 22:27:07 +02:00

Compare