From fe67927c24101a5bb0e81372b254504f9beb0ae1 Mon Sep 17 00:00:00 2001
From: ro <iam@roiskinda.cool>
Date: Fri, 9 Feb 2024 17:21:07 -0600
Subject: [PATCH] Used laravel validation for appeal form

Switched valdiation from checking for empty strings to using Laravel's
built in form validation. It's pretty.
---
 app/Http/Controllers/AppealController.php | 38 ++++++++++-------------
 1 file changed, 17 insertions(+), 21 deletions(-)

diff --git a/app/Http/Controllers/AppealController.php b/app/Http/Controllers/AppealController.php
index 148e24b..1bb3d43 100644
--- a/app/Http/Controllers/AppealController.php
+++ b/app/Http/Controllers/AppealController.php
@@ -30,27 +30,23 @@ class AppealController extends Controller
                     'error' => 'Appeal already in process for Location',
                 ]);
             } else {
-                if (
-                    empty($request->location)
-                    || empty($request->location_admin)
-                    || empty($request->sponsor)
-                    || empty($request->appeal_description)
-                ) {
-                    return back()->withErrors([
-                        'error' => 'All fields are required',
-                    ]);
-                } else {
-                    $new = Appeal::create([
-                        'uuid'           => Uuid::uuid4(),
-                        'location'       => $request->location,
-                        'location_admin' => $request->location_admin,
-                        'sponsor'        => $request->sponsor,
-                        'description'    => $request->appeal_description,
-                        'approved'       => false,
-                        'reviewed'       => false,
-                    ]);
-                    Mail::to(env('TBS_ADMIN_EMAIL'))->send(new LocationAppeal($request->location, $request->sponsor));
-                }
+                $clean = $request->validate([
+                    'location'           => ['required'],
+                    'local_admin'        => ['required'],
+                    'local_sponsor'      => ['required'],
+                    'appeal_description' => ['required'],
+                ]);
+
+                $new = Appeal::create([
+                    'uuid'           => Uuid::uuid4(),
+                    'location'       => $request->location,
+                    'location_admin' => $request->location_admin,
+                    'sponsor'        => $request->sponsor,
+                    'description'    => $request->appeal_description,
+                    'approved'       => false,
+                    'reviewed'       => false,
+                ]);
+                Mail::to(env('TBS_ADMIN_EMAIL'))->send(new LocationAppeal($request->location, $request->sponsor));
             }
             //return redirect('/appeals');
             return back()->with('message', "Appeal Filed");